Skip to content

Conversation

@chargome
Copy link
Member

closes #11572

@chargome chargome self-assigned this Oct 23, 2024
@vercel
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:19am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 0:19am

@codecov
Copy link

codecov bot commented Oct 23, 2024

Bundle Report

Changes will increase total bundle size by 5.14kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.52MB 4.45kB (0.06%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 693 bytes (0.01%) ⬆️

@stephanie-anderson
Copy link
Contributor

Haven't had the chance to check - I think this is not up to date with master. Have we checked if hidden pages are properly excluded from that navigation? I can think of the metrics page in develop docs as a good example:

Screenshot 2024-10-23 at 17 53 19

@chargome
Copy link
Member Author

@stephanie-anderson this is up to date with master, metrics is not excluded – or maybe I don't understand the question 🤔

@stephanie-anderson
Copy link
Contributor

Oh, this page was never hidden in the first place 🙈 I was referring to whether we checked if the frontmatter config sidebar_hidden would be properly respected (as in, it would never be a previous or next page suggestion)

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool addition to the docs!

@chargome chargome merged commit 4228c99 into master Oct 30, 2024
13 checks passed
@chargome chargome deleted the cg/navigation-buttons branch October 30, 2024 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show links to previous and next pages

5 participants