feat(platform): Display requested title in platform redirect #11646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chargome
requested review from
cstavitsky,
lizokm,
maxkosty and
stephanie-anderson
Bundle ReportChanges will increase total bundle size by 158 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Contributor
|
Oh, how fast! Thanks for implementing this. I initially thought we would add the page titles and descriptions in the list of platforms (instead of .NET etc), but this is also an option. Would let @lizokm decide on what she would prefer |
Member
Author
|
@stephanie-anderson yeah I just went with lizas most recent comment in the connected issue |
stephanie-anderson
approved these changes
Oct 24, 2024
cstavitsky
approved these changes
Oct 24, 2024
Contributor
cstavitsky
left a comment
cstavitsky
left a comment
There was a problem hiding this comment.
Nice!!! Excited to see this 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10517
With this change we display the title and description of the requested page (if it exists).
before
after
The risk here is that different platforms might have different titles and descriptions for the same page, and in this PR we just take the first one we find (which is usually .NET I think). I tested out some pages and it seemed to work fine every time.