Skip to content

Conversation

@stephanie-anderson
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 4:03pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 4:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:03pm

@codecov
Copy link

codecov bot commented Oct 31, 2024

Bundle Report

Changes will increase total bundle size by 714 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.38MB 681 bytes (0.01%) ⬆️
sentry-docs-edge-server-array-push 333.11kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 36 bytes (0.0%) ⬆️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better and makes sense 👍

font-weight: 300;
font-size: 1.3rem;
color: var(--foreground-secondary);
color: var(--desatPurple2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there a special reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was never done by our design team, and I think the grey that we had before simply was off. Personally, I think it looks much cleaner now

before

Screenshot 2024-10-31 at 16 59 02 Screenshot 2024-10-31 at 16 58 58

after

Screenshot 2024-10-31 at 16 58 44 Screenshot 2024-10-31 at 16 58 39

what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the color in light mode is a bit strong but that's fine 👍

@stephanie-anderson stephanie-anderson merged commit e96738f into master Oct 31, 2024
12 checks passed
@stephanie-anderson stephanie-anderson deleted the develop-sdks branch October 31, 2024 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants