feat(platform): Add placeholder for automatically detecting js package #11724
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 2.26kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
| @@ -1,17 +0,0 @@ | |||
| ```javascript {13} {filename:sentry.client.config.js} | |||
There was a problem hiding this comment.
m: These filenames are important, I don't think we can just remove these and have the blocks generic :(
There was a problem hiding this comment.
hmm, maybe we can add a frontmatter bit with the filename somewhere?
There was a problem hiding this comment.
You are right, I missed that. That's actually bad since this will force us again to create separate files.
@a-hariti adding config file names would get messy since some frameworks have up to three different config files depending on the runtime
There was a problem hiding this comment.
I'm not sure if the need for this feature is actually worth the time, maybe we'll just close it and not overcomplicate this here – wdyt?
closes #9013
The new placeholder
___JS_PACKAGE___can be used within code blocks and automatically injects the corresponding node package (e.g. resolves to@sentry/react). So code snippets in platform includes that basically contain the same code apart from the import statement can now be replaced with a single code snippet.The pr also includes an example where this feature is used for replay canvas.