Skip to content

Conversation

@bruno-garcia
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 3:44pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 3:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:44pm

@codecov
Copy link

codecov bot commented Nov 7, 2024

Bundle Report

Changes will increase total bundle size by 301.72kB (1.69%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.89MB 301.73kB (3.51%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small language tweaks. Thanks for adding!

Comment on lines +29 to +31
Note that [Unity has an Android crash handler which takes treats the crash information as a string](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html). This doesn't allow Sentry to symbolicate the crash and in result becomes a very low quality crash dump.
We recomment disalbing that through: `-androidChainedSignalHandlerBehavior:disabled`. For more information, [read the Unity documentation on this topic](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that [Unity has an Android crash handler which takes treats the crash information as a string](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html). This doesn't allow Sentry to symbolicate the crash and in result becomes a very low quality crash dump.
We recomment disalbing that through: `-androidChainedSignalHandlerBehavior:disabled`. For more information, [read the Unity documentation on this topic](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html).
Note, that Unity has an [Android crash handler](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html), which treats crash information as a string. This doesn't allow Sentry to symbolicate the crash, which becomes a very low-quality crash dump as a result. We recommend disabling it through: `-androidChainedSignalHandlerBehavior:disabled`. For more information, [read the Unity documentation](https://docs.unity3d.com/6000.0/Documentation/Manual/android-handle-crashes.html).

@bitsandfoxes
Copy link
Contributor

I'm waiting on the customer providing/confirming that this does help them in any way.

@getsantry getsantry bot added the Stale label Dec 5, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Dec 6, 2024
@bitsandfoxes
Copy link
Contributor

@romtsn, I know you made the sample work in the end. Was this change necessary? Did this work out?

@getsantry getsantry bot added the Stale label Jan 2, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jan 2, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Jan 3, 2025
@bitsandfoxes
Copy link
Contributor

Closing this as we did not end up using this to get the SDKs in a working state.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants