Skip to content

Conversation

@Jeffreyhung
Copy link
Member

DESCRIBE YOUR PR

We are planning to replace the current usage of getsentry-release bot with a GitHub App, this PR will update the docs to include updated code template.

More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:15pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 7:15pm

@Jeffreyhung Jeffreyhung changed the title use Github App instead of PAT feat(releases): Update docs to use GitHub App instead of service account PAT Nov 12, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Bundle Report

Changes will increase total bundle size by 126 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 132 bytes (0.0%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I added a suggestion to reformat one of the links.

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeffreyhung
Copy link
Member Author

Will be waiting for approval on the devinfra side on this before rolling this out

@Jeffreyhung
Copy link
Member Author

Got a green light on this! Merging!

@Jeffreyhung Jeffreyhung merged commit c2a1f13 into master Dec 4, 2024
11 checks passed
@Jeffreyhung Jeffreyhung deleted the update-releases-dev-docs branch December 4, 2024 00:02
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
…unt PAT (#11805)

* use Github App instead of PAT

* include instructions for creating rulesets

* fix syntaxs

* Move the json file to the public folder

* Testing

* dummy commit to trigger build on docs site

* revert dummy change

* fix the link to json file

* Apply suggestions from code review

Co-authored-by: Liza Mock <[email protected]>

* fix the link

* update the action app version

* not required codeowner review by default

* update default ruleset to include `release-bot` team for getsentry-bot

---------

Co-authored-by: Liza Mock <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants