Skip to content

Conversation

@brustolin
Copy link
Contributor

Added source-coxtext as onboarding component option in order to manipulate the code snippet related to upload debug symbols.

closes #11810

@vercel
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:31pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:31pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:31pm

@codecov
Copy link

codecov bot commented Nov 14, 2024

Bundle Report

Changes will increase total bundle size by 393 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 193 bytes (0.0%) ⬆️
sentry-docs-client-array-push 8.94MB 200 bytes (0.0%) ⬆️

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, but the current approach is quite confusing to me right now.

Comment on lines 3 to 7
You can also upload your code for source context. This feature allows Sentry to display snippets of your code next to the event stack traces.

<OnboardingOptionButtons
options={[{ id:"source-context", checked: false }]}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: I think this should be directly above the code snippets. The experience is quite confusing to me now as it's I have no clue what the checkbox is doing, cause I don't see the code snippets.

CleanShot 2024-11-14 at 16 10 11@2x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brustolin, I think it would be better to somehow make the button non sticky. When I navigate down to the SentryFastlane plugin, I now see the button but it misses explanation.
CleanShot 2024-11-18 at 15 56 35@2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But It affects all the code snippets in the page. And since the entire page is about uploading debug information, I think this makes sense.

Its like this in all other pages that this component is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its like this in all other pages that this component is used.

Maybe they could also be improved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, it's better than before. Step by step.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit a3aded6 into master Nov 19, 2024
13 checks passed
@brustolin brustolin deleted the feat/onboard-source-context-option branch November 19, 2024 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@brustolin brustolin restored the feat/onboard-source-context-option branch January 30, 2025 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight better the effects of the "include sources" option

3 participants