-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(apple): Add onboarding source context Option #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 393 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
…om/getsentry/sentry-docs into feat/onboard-source-context-option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, but the current approach is quite confusing to me right now.
| You can also upload your code for source context. This feature allows Sentry to display snippets of your code next to the event stack traces. | ||
|
|
||
| <OnboardingOptionButtons | ||
| options={[{ id:"source-context", checked: false }]} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brustolin, I think it would be better to somehow make the button non sticky. When I navigate down to the SentryFastlane plugin, I now see the button but it misses explanation.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But It affects all the code snippets in the page. And since the entire page is about uploading debug information, I think this makes sense.
Its like this in all other pages that this component is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its like this in all other pages that this component is used.
Maybe they could also be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, it's better than before. Step by step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Added source-coxtext as onboarding component option in order to manipulate the code snippet related to upload debug symbols.
closes #11810