Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Nov 14, 2024

We've removed some APIs in Java SDK v8. This PR replaces / removes docs for those.

Here's the changelog: https://github.com/getsentry/sentry-java/blob/8.x.x/CHANGELOG.md

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:50am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 10:50am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 10:50am

@codecov
Copy link

codecov bot commented Nov 14, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be part of this pr, however, compared to the migration guide, here are some things I found.

  • enableTracing option (a.k.a enable-tracing) is still in the docs
  • In docs/platforms/android/metrics/index.mdx we should mention, that metrics are no longer supported in 8.x.x or remove the metrics docs altogether

@adinauer
Copy link
Member Author

enableTracing option (a.k.a enable-tracing) is still in the docs
In docs/platforms/android/metrics/index.mdx we should mention, that metrics are no longer supported in 8.x.x or remove the metrics docs altogether

We have separate issues to track changing / removing those.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer changed the base branch from master to feat/java-v8-changes November 20, 2024 04:31
@adinauer
Copy link
Member Author

I've retargeted this PR to a new branch so we can collect all changes we want to merge after v8 GAs.

@adinauer adinauer merged commit 39be89f into feat/java-v8-changes Nov 20, 2024
11 checks passed
@adinauer adinauer deleted the feat/java-v8-deprecations branch November 20, 2024 04:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants