Skip to content

Conversation

@viglia
Copy link
Contributor

@viglia viglia commented Nov 18, 2024

Add note to the stack trace rules to explain that a subset of those rules will now be applied to profiles as well.


Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 11:11am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 11:11am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 11:11am

@codecov
Copy link

codecov bot commented Nov 18, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.6MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@viglia viglia marked this pull request as ready for review November 18, 2024 15:28
@viglia viglia requested review from a team November 18, 2024 15:29
lizokm

This comment was marked as resolved.

@viglia

This comment was marked as resolved.

@viglia viglia merged commit 43228b7 into master Dec 10, 2024
11 checks passed
@viglia viglia deleted the viglia/feat/add-note-for-profiles-stack-trace-rules branch December 10, 2024 08:17
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants