Skip to content

add instructions to setup Android continuous profiling #11872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefanosiano merged 11 commits into from
Mar 25, 2025
Merged

add instructions to setup Android continuous profiling #11872

stefanosiano merged 11 commits into from
Mar 25, 2025

Conversation

@stefanosiano
Copy link
Contributor

@stefanosiano stefanosiano commented Nov 19, 2024

DESCRIBE YOUR PR

add instructions to setup Android continuous profiling

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:07pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 2:07pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 2:07pm

@codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.68MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.98MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 893.8kB -0.0%
static/chunks/8429-*.js -3 bytes 371.26kB -0.0%
static/6nqJa71fiQDSe3tbvELkX/_buildManifest.js (New) 581 bytes 581 bytes 100.0% 🚀
static/6nqJa71fiQDSe3tbvELkX/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/65t9T0LQTVPQPB4ljdijm/_buildManifest.js (Deleted) -581 bytes 0 bytes -100.0% 🗑️
static/65t9T0LQTVPQPB4ljdijm/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
7517.js -3 bytes 1.66MB -0.0%
../instrumentation.js -3 bytes 910.93kB -0.0%
7688.js -3 bytes 886.9kB -0.0%

coolguyzone
coolguyzone reviewed Nov 20, 2024
View reviewed changes
coolguyzone
coolguyzone reviewed Nov 20, 2024
View reviewed changes
coolguyzone
coolguyzone approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a formatting suggestion, otherwise looks good! Thanks for the update 🫡

@stefanosiano
Copy link
Contributor Author

stefanosiano commented Nov 21, 2024 •
edited
Loading

I'll merge this PR as soon as we release the Java SDK v8 with the continuous profiler (soon)

@stefanosiano stefanosiano mentioned this pull request Nov 21, 2024
Merged
7 tasks
@getsantry
Copy link
Contributor

getsantry bot commented Dec 13, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 13, 2024
@coolguyzone
Copy link
Contributor

coolguyzone commented Dec 16, 2024

Just commenting to keep this alive.

@getsantry
Copy link
Contributor

getsantry bot commented Jan 7, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 7, 2025
@coolguyzone
Copy link
Contributor

coolguyzone commented Jan 7, 2025

@stefanosiano can this be merged now?

@getsantry getsantry bot removed the Stale label Jan 8, 2025
@stefanosiano
Copy link
Contributor Author

stefanosiano commented Jan 8, 2025

@coolguyzone not yet, as the backend is still fixing last issues with Android profiles

@coolguyzone
Copy link
Contributor

coolguyzone commented Jan 8, 2025

@stefanosiano Cool, just checking in, wanted to make sure it didn't get lost in the shuffle.

@getsantry getsantry bot added the Stale label Jan 30, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jan 30, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@kahest kahest removed the Stale label Jan 30, 2025
@kahest
Copy link
Contributor

kahest commented Jan 30, 2025

^ just confirming that we're still waiting for the feature release in order to merge these docs

kahest
kahest reviewed Mar 7, 2025
View reviewed changes
kahest
kahest reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, overall lgtm 👍
needs to resolve merge conflicts from the main branch in the onboarding snippet

@stefanosiano
Merge branch 'master' into stefanosiano/android-continuous-profiling
4f35abd 
# Conflicts:
#	docs/platforms/android/index.mdx
@stefanosiano
merged main
067f358 
fixed onboarding
Added billing note as an Alert
@stefanosiano stefanosiano enabled auto-merge (squash) March 25, 2025 10:58
@stefanosiano stefanosiano disabled auto-merge March 25, 2025 10:59
kahest
kahest reviewed Mar 25, 2025
View reviewed changes
@stefanosiano stefanosiano enabled auto-merge (squash) March 25, 2025 13:23
@stefanosiano stefanosiano disabled auto-merge March 25, 2025 13:36
@stefanosiano stefanosiano enabled auto-merge (squash) March 25, 2025 13:37
@stefanosiano stefanosiano merged commit 11f34f9 into master Mar 25, 2025
11 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/android-continuous-profiling branch March 25, 2025 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

+1 more reviewer

@kahest kahest kahest left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stefanosiano @coolguyzone @kahest