Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

DESCRIBE YOUR PR

Updated the section on proxy support to match the upcoming socks5 proxy support feature in sentry-native.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 9:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 9:52am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 9:52am

@codecov
Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.28MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.29MB 6 bytes (-0.0%) ⬇️

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would only highlight technical terms like HTTP, CONNECT, and SOCKS5 with backticks in the prose.

@JoshuaMoelans JoshuaMoelans force-pushed the feat/native_proxy_support_joshua branch from 99a8f14 to 7e939c0 Compare November 25, 2024 09:38
@JoshuaMoelans JoshuaMoelans merged commit d7679b2 into master Nov 25, 2024
11 checks passed
@JoshuaMoelans JoshuaMoelans deleted the feat/native_proxy_support_joshua branch November 25, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants