Skip to content

chore(platform): React 19 compatibility #11901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2024
Merged

chore(platform): React 19 compatibility #11901

merged 5 commits into from
Nov 22, 2024

Conversation

@chargome
Copy link
Member

@chargome chargome commented Nov 21, 2024 •
edited
Loading

  • Updates radix ui to be fully compatible with react 19.
  • Ignores hydration errors on html and body element (due to darkmode)
  • Silences sass deprecation warnings (we should unify styling in this project at some point and maybe get rid of sass)
  • Bumps several dependencies that caused errors
  • Fixes ts errors

@chargome chargome self-assigned this Nov 21, 2024
@chargome chargome requested a review from a-hariti November 21, 2024 14:36
@vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:47am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:47am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:47am

@codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 173.7kB (-0.87%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.38MB 98.66kB (0.96%) ⬆️
sentry-docs-client-array-push 9.02MB 272.36kB (-2.93%) ⬇️

@chargome chargome force-pushed the cg/react-19-follow-up branch from 422c703 to b9da8e9 Compare November 22, 2024 08:44
@chargome chargome changed the title chore(platform): Update radix ui packages chore(platform): React 19 compability Nov 22, 2024
@chargome chargome changed the title chore(platform): React 19 compability chore(platform): React 19 compatibility Nov 22, 2024
@chargome chargome requested a review from lforst November 22, 2024 10:49
@chargome chargome merged commit 567b74d into master Nov 22, 2024
13 checks passed
@chargome chargome deleted the cg/react-19-follow-up branch November 22, 2024 11:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-hariti a-hariti Awaiting requested review from a-hariti

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chargome chargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chargome @lforst