Skip to content

Clean up dev console warnings #11916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Clean up dev console warnings #11916

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c744ef
use esm on tailwind config to fix cjs warnings
a-hariti Nov 22, 2024
1dc30bb
use next/link instead of <a>
a-hariti Nov 22, 2024
b5c4c4b
ignore punnycode deprecation warning
a-hariti Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import {Fragment} from 'react';
import {HamburgerMenuIcon} from '@radix-ui/react-icons';
import Image from 'next/image';
import Link from 'next/link';

import SentryLogoSVG from 'sentry-docs/logos/sentry-logo-dark.svg';

Expand Down Expand Up @@ -44,7 +45,7 @@ export function Header({pathname, searchPlatforms, noSearch}: Props) {
</label>
</button>
)}
<a
<Link
href="/"
title="Sentry error monitoring"
className="flex flex-shrink-0 items-center lg:w-[calc(var(--sidebar-width,300px)-2rem)] text-2xl font-medium text-[var(--foreground)]"
Expand All @@ -58,7 +59,7 @@ export function Header({pathname, searchPlatforms, noSearch}: Props) {
/>
</div>
Docs
</a>
</Link>
{!noSearch && (
<div className="hidden md:flex justify-center lg:justify-start w-full px-6">
<Search path={pathname} searchPlatforms={searchPlatforms} showChatBot />
Expand Down
12 changes: 6 additions & 6 deletions tailwind.config.js → tailwind.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
const defaultTheme = require('tailwindcss/defaultTheme');
import defaultTheme from 'tailwindcss/defaultTheme';

import Typography from '@tailwindcss/typography';
import Forms from '@tailwindcss/forms';
import {
isolateInsideOfContainer,
scopedPreflightStyles,
} from 'tailwindcss-scoped-preflight';

/** @type {import('tailwindcss').Config} */
module.exports = {
export default {
darkMode: ['selector', '.dark'],
content: ['./app/**/*.{js,ts,jsx,tsx}', './src/components/**/*.{js,ts,jsx,tsx,mdx}'],
theme: {
Expand Down Expand Up @@ -60,10 +62,8 @@ module.exports = {
},
},
plugins: [
require('@tailwindcss/typography'),
require('@tailwindcss/forms')({
strategy: 'class',
}),
Typography,
Forms({strategy: 'class'}),
scopedPreflightStyles({
// pretty minimalistic example. Same options as in the previous example are available
isolationStrategy: isolateInsideOfContainer('.tw-app'),
Expand Down
Loading