Skip to content

Conversation

@martinhaintz
Copy link
Contributor

Update the data scrubbing default values

After investigating a data scrubbing issue I found out, that the list in the docs differs from the list defined in the relay code.

list in the current docs:

  - password
  - secret
  - passwd
  - api_key
  - apikey
  - access_token
  - auth
  - credentials
  - mysql_pwd
  - stripetoken
  - card[number]
  - github_token
  - privatekey
  - private_key

list in the current relay code:

password|secret|passwd|api_key|apikey|auth|credentials|mysql_pwd|privatekey|private_key|token|bearer

comparing these two lists I updated the docs and removed:

- access_token
- stripetoken
- card[number]
- github_token

and added these:

- token
- bearer

@iambriccardo can you have a look and verify that my assumptions are correct?

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:54am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Nov 26, 2024 10:54am
develop-docs ⬜️ Ignored (Inspect) Nov 26, 2024 10:54am

@untitaker
Copy link
Member

untitaker commented Nov 27, 2024

suggest to file a PR against relay with a code comment that reminds to update docs :)))

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinhaintz martinhaintz marked this pull request as ready for review December 2, 2024 08:43
@martinhaintz martinhaintz merged commit 787a709 into master Dec 2, 2024
11 checks passed
@martinhaintz martinhaintz deleted the martinhaintz/update-server-side-data-scrubbing-defaults branch December 2, 2024 08:43
aliu39 pushed a commit that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants