Skip to content

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Nov 27, 2024

add a product landing page for feature flags!

url will be https://docs.sentry.io/product/explore/feature-flags/

figjam ref mapping out the docs

localhost_3000_product_explore_feature-flags_ (1)

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 11:15pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2024 11:15pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2024 11:15pm

@michellewzhang michellewzhang requested review from a team November 27, 2024 06:56
Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will increase total bundle size by 162 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 168 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️


In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking.

## Set Up Your Language-Specific SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this (and the next title) be sub-titles under ## Setup? idk

Suggested change
## Set Up Your Language-Specific SDK
### Set Up Your Language-Specific SDK


## Setup

In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking.
In order to take advantage of the full feature flag experience, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking.


Learn more about the languages we currently support and how to set up the SDK:
* [JavaScript](/platforms/javascript/feature-flags/)
* [Python](/platforms/python/feature-flags/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links both 404, I'm guessing those pages are in development as well; let's make sure we don't merge this until those urls are live.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! LGTM, see my comment about dependencies before merging 🫡 🦃

---
title: "Feature Flags"
sidebar_order: 100
description: "Learn how to set up and interact with Sentry's feature flag evaluation tracking and feature flag change tracking."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Learn how to set up and interact with Sentry's feature flag evaluation tracking and feature flag change tracking."
description: "Learn how to set up and interact with Sentry's feature flag evaluation and feature flag change tracking."


## Touchpoints

Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data:
Feature flag insights can be found by navigating to the [Issue Details](product/issues/issue-details/) page for any error event. There are two places where you can interact with flag data:


Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data:
* Flag updates (changes, deletions, and additions) will appear as a series on the event and user volume chart.
* Flag evaluations will appear in the Feature Flag section in Issue Details as a table, with "suspect" flag predictions highlighted in yellow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write a line or two describing how we determine what's suspect? (broadly speaking)

* Flag updates (changes, deletions, and additions) will appear as a series on the event and user volume chart.
* Flag evaluations will appear in the Feature Flag section in Issue Details as a table, with "suspect" flag predictions highlighted in yellow.

Learn more about how to interact with feature flag insights within the Sentry UI by reading the [Issue Details docs](/product/issues/issue-details/#feature-flags/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this seems like something we should be saying right here on the product index!


Learn more about how to interact with feature flag insights within the Sentry UI by reading the [Issue Details docs](/product/issues/issue-details/#feature-flags/).

## Setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Setup
## Set Up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that's how we write set up on our docs site, so updating for consistency 👁️


## Set Up Your Integration-Specific Webhook

In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it may communicate feature flag changes with Sentry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it may communicate feature flag changes with Sentry.
In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it can communicate feature flag changes with Sentry.

@ryan953
Copy link
Member

ryan953 commented Dec 2, 2024

Looks like this got pulled into the big docs PR here: https://github.com/getsentry/sentry-docs/pull/12005/files#diff-9f7ef91deded62672a82ddc124ead4aa705d3ad9ef0a76f5ed6f9c4017d9715c

closing this so we can focus there.

@ryan953 ryan953 closed this Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@michellewzhang michellewzhang deleted the mz/ff-index branch March 17, 2025 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants