-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(flags): add product index page for feature flags #11969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 162 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
a2f1d71
to
0bb8b8e
Compare
|
||
In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking. | ||
|
||
## Set Up Your Language-Specific SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this (and the next title) be sub-titles under ## Setup
? idk
## Set Up Your Language-Specific SDK | |
### Set Up Your Language-Specific SDK |
|
||
## Setup | ||
|
||
In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to take advantage of the full feature flag experience available, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking. | |
In order to take advantage of the full feature flag experience, there are two steps necessary to set up **feature flag evaluation tracking** and **feature flag change tracking**. The first step — setting up the language-specific SDK — is necessary for evaluation tracking, and the second step — setting up your integration-specific webhook — is necessary for change tracking. |
|
||
Learn more about the languages we currently support and how to set up the SDK: | ||
* [JavaScript](/platforms/javascript/feature-flags/) | ||
* [Python](/platforms/python/feature-flags/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links both 404, I'm guessing those pages are in development as well; let's make sure we don't merge this until those urls are live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding! LGTM, see my comment about dependencies before merging 🫡 🦃
--- | ||
title: "Feature Flags" | ||
sidebar_order: 100 | ||
description: "Learn how to set up and interact with Sentry's feature flag evaluation tracking and feature flag change tracking." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "Learn how to set up and interact with Sentry's feature flag evaluation tracking and feature flag change tracking." | |
description: "Learn how to set up and interact with Sentry's feature flag evaluation and feature flag change tracking." |
|
||
## Touchpoints | ||
|
||
Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data: | |
Feature flag insights can be found by navigating to the [Issue Details](product/issues/issue-details/) page for any error event. There are two places where you can interact with flag data: |
|
||
Feature flag insights can be found by navigating to the Issue Details page for any error event. There are two places where you can interact with flag data: | ||
* Flag updates (changes, deletions, and additions) will appear as a series on the event and user volume chart. | ||
* Flag evaluations will appear in the Feature Flag section in Issue Details as a table, with "suspect" flag predictions highlighted in yellow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we write a line or two describing how we determine what's suspect? (broadly speaking)
* Flag updates (changes, deletions, and additions) will appear as a series on the event and user volume chart. | ||
* Flag evaluations will appear in the Feature Flag section in Issue Details as a table, with "suspect" flag predictions highlighted in yellow. | ||
|
||
Learn more about how to interact with feature flag insights within the Sentry UI by reading the [Issue Details docs](/product/issues/issue-details/#feature-flags/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this seems like something we should be saying right here on the product index!
|
||
Learn more about how to interact with feature flag insights within the Sentry UI by reading the [Issue Details docs](/product/issues/issue-details/#feature-flags/). | ||
|
||
## Setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Setup | |
## Set Up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that's how we write set up on our docs site, so updating for consistency 👁️
|
||
## Set Up Your Integration-Specific Webhook | ||
|
||
In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it may communicate feature flag changes with Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it may communicate feature flag changes with Sentry. | |
In order to gain access to **feature flag change tracking**, you need to set up a webhook with your specific integration, so that it can communicate feature flag changes with Sentry. |
Looks like this got pulled into the big docs PR here: https://github.com/getsentry/sentry-docs/pull/12005/files#diff-9f7ef91deded62672a82ddc124ead4aa705d3ad9ef0a76f5ed6f9c4017d9715c closing this so we can focus there. |
add a product landing page for feature flags!
url will be https://docs.sentry.io/product/explore/feature-flags/
figjam ref mapping out the docs