Skip to content

docs(nuxt): Add installation methods #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2024
Merged

docs(nuxt): Add installation methods #11983

merged 4 commits into from
Nov 29, 2024

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Nov 27, 2024 •
edited
Loading

DESCRIBE YOUR PR

Part of #11978

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 28.11.
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am

@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 657 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 663 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.11MB 6 bytes (-0.0%) ⬇️

@s1gr1d s1gr1d self-assigned this Nov 28, 2024
@s1gr1d s1gr1d force-pushed the sig/nuxt-installation-methods branch from d396dd6 to caa2c80 Compare November 28, 2024 15:14
@s1gr1d s1gr1d marked this pull request as ready for review November 28, 2024 15:15
Lms24
Lms24 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I had some minor comments and suggestions but otherwise :shipit:

@s1gr1d s1gr1d merged commit 3d4430c into master Nov 29, 2024
11 checks passed
@s1gr1d s1gr1d deleted the sig/nuxt-installation-methods branch November 29, 2024 09:23
@s1gr1d s1gr1d mentioned this pull request Nov 27, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@coolguyzone coolguyzone Awaiting requested review from coolguyzone

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

@s1gr1d s1gr1d

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s1gr1d @Lms24