Skip to content

Conversation

@markushi
Copy link
Member

DESCRIBE YOUR PR

As discussed span_id is always required. Update docs to clarify a random span_id can be provided if none is available.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@markushi markushi requested review from cleptric and lforst November 29, 2024 11:00
@vercel
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 5:23pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:23pm
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:23pm

@lforst
Copy link
Contributor

lforst commented Nov 29, 2024

This is a bit misleading imo and leaves out way too much context. If we are noting something like this down we need to elaborate why. (ie explain twp)

@markushi markushi merged commit 139aef0 into master Dec 5, 2024
10 checks passed
@markushi markushi deleted the chore/trace-context-span-id branch December 5, 2024 05:49
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* Clarify span_id attribute

* Link TwP docs

* Update develop-docs/sdk/data-model/event-payloads/contexts.mdx

Co-authored-by: Luca Forstner <[email protected]>

---------

Co-authored-by: Luca Forstner <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants