Skip to content

Keep platform selector in sync with pathname #12049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Keep platform selector in sync with pathname #12049

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a51ac34
is it reactive enough?
a-hariti Dec 4, 2024
606bb28
fix type
a-hariti Dec 4, 2024
b356e03
.
a-hariti Dec 4, 2024
9b4b843
[getsentry/action-github-commit] Auto commit
getsantry[bot] Dec 4, 2024
0b848ad
use next/router
a-hariti Dec 5, 2024
c6bf7b3
[getsentry/action-github-commit] Auto commit
getsantry[bot] Dec 5, 2024
579d733
fix import
a-hariti Dec 5, 2024
668c799
[getsentry/action-github-commit] Auto commit
getsantry[bot] Dec 5, 2024
7e86134
remove hack
a-hariti Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/components/platformSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {Combobox, ComboboxItem, ComboboxList, ComboboxProvider} from '@ariakit/r
import {CaretRightIcon, CaretSortIcon, MagnifyingGlassIcon} from '@radix-ui/react-icons';
import * as RadixSelect from '@radix-ui/react-select';
import {matchSorter} from 'match-sorter';
import {usePathname} from 'next/navigation';
import {usePathname, useRouter} from 'next/navigation';

import {PlatformIcon} from 'sentry-docs/components/platformIcon';
import {Platform, PlatformGuide, PlatformIntegration} from 'sentry-docs/types';
Expand Down Expand Up @@ -90,13 +90,12 @@ export function PlatformSelector({
return matches_;
}, [searchValue, currentPlatformKey, platformsAndGuides]);

const router = useRouter();
const onPlatformChange = (platformKey: string) => {
const platform_ = platformsAndGuides.find(platform => platform.key === platformKey);
if (platform_) {
localStorage.setItem('active-platform', platform_.key);
// feels wrong to use window.location here,
// but router.push is not working on mobile for some reason
window.location.href = platform_.url;
router.push(platform_.url);
}
};

Expand Down
Loading