Skip to content

Conversation

@IanVS
Copy link
Contributor

@IanVS IanVS commented Dec 10, 2024

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

There were a few places on this page still using the deprecated wrapCreateBrowserRouter method.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

There were a few places on this page still using the deprecated `wrapCreateBrowserRouter` method.
@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 2:47pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:47pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:47pm

@vercel
Copy link

vercel bot commented Dec 10, 2024

@IanVS is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@coolguyzone
Copy link
Contributor

@AbhiPrasad can you take a look?

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @IanVS!

@getsantry
Copy link
Contributor

getsantry bot commented Jan 3, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 3, 2025
@IanVS
Copy link
Contributor Author

IanVS commented Jan 3, 2025

It's been approved, maybe it can be merged instead of closed?

@AbhiPrasad
Copy link
Member

sorry @IanVS I just think we missed this, merging now!

@AbhiPrasad AbhiPrasad merged commit 3ff4229 into getsentry:master Jan 3, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants