Skip to content

Conversation

@vashov
Copy link
Contributor

@vashov vashov commented Dec 10, 2024

DESCRIBE YOUR PR

Correct the dotnet docs regarding the valid values for MaxRequestBodySize.

Based on sentry-dotnet code:
https://github.com/getsentry/sentry-dotnet/blob/main/src/Sentry/Extensibility/RequestSize.cs
None is a valid

I encountered the following error:
"Message":"Failed to convert configuration value at 'Sentry:MaxRequestBodySize' to type 'Sentry.Extensibility.RequestSize'
when setting the appsettings.json value Sentry:MaxRequestBodySize to never

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:04pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 5:04pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 5:04pm

@vercel
Copy link

vercel bot commented Dec 10, 2024

@vashov is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vashov vashov changed the title Update dotnet docs options.mdx with RequestSize valid value docs(dotnet): valid value for RequestSize Dec 11, 2024
@coolguyzone
Copy link
Contributor

@bitsandfoxes can you take a look at this one?

@getsantry getsantry bot added the Stale label Jan 2, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jan 2, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Jan 3, 2025
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@bitsandfoxes bitsandfoxes merged commit 00e7000 into getsentry:master Jan 7, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants