Skip to content

Conversation

@stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Dec 12, 2024

DESCRIBE YOUR PR

added gradle plugin auto-instrumentation issue with minified libraries to troubleshooting page
changed Android TTFD timeout from 30 to 25 seconds

Closes getsentry/sentry-android-gradle-plugin#768
Relates to getsentry/sentry-java#3831

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

added gradle plugin auto-instrumentation issue with minified libraries to troubleshooting page
@stefanosiano stefanosiano requested a review from romtsn December 12, 2024 12:54
@vercel
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 11:33am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 11:33am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 11:33am

@codecov
Copy link

codecov bot commented Dec 12, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stefanosiano stefanosiano merged commit 5366f68 into master Dec 13, 2024
11 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/minified-libs-and-ttfd-timeout branch December 13, 2024 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Failed: Error while instrumenting Hv.rMN

3 participants