Skip to content

Conversation

@michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Dec 12, 2024

add specific info in the docs about which MIME types are supported / renderable for event attachments.

based on previewAttachmentTypes.tsx:

https://github.com/getsentry/sentry/blob/bf167f9145882b76bc1f38eb4b7f62bedf6d9b71/static/app/components/events/attachmentViewers/previewAttachmentTypes.tsx#L7-L32

closes #8471

@vercel
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 9:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Dec 12, 2024 9:42pm
develop-docs ⬜️ Ignored (Inspect) Dec 12, 2024 9:42pm

@michellewzhang michellewzhang requested review from a team and krystofwoldrich December 12, 2024 21:37
@codecov
Copy link

codecov bot commented Dec 12, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good.

@michellewzhang michellewzhang merged commit f0b2929 into master Dec 19, 2024
11 checks passed
@michellewzhang michellewzhang deleted the mz/add-mimetype branch December 19, 2024 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add attachments types supporting preview

3 participants