fix(js): Fix docs for using feedback with the Loader #12140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
requested review from
billyvg,
c298lee,
lforst,
ryan953 and
whitep4nth3r
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mydea
changed the title
lforst
approved these changes
Dec 16, 2024
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Co-authored-by: Salma Alam-Naylor <[email protected]>
whitep4nth3r
approved these changes
Dec 16, 2024
ryan953
reviewed
Dec 16, 2024
| }; | ||
| ``` | ||
|
|
||
| If you're using CDN bundles instead of NPM packages, you need to load the User Feedback integration CDN bundle in addition to your browser bundle: |
Member
There was a problem hiding this comment.
"in addition" seems like it should go away. People should pick one CDN script with the combination of integrations that they want to have.
Member
Author
There was a problem hiding this comment.
yeah, good point, we call this out in the snippet anyhow!
mydea
commented
Dec 16, 2024
coolguyzone
approved these changes
Dec 16, 2024
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for the update! LGTM
billyvg
approved these changes
Dec 16, 2024
matejminar
added a commit
to getsentry/sentry
that referenced
this pull request
Dec 17, 2024
Closes #82142 Closes #66263 Relates to getsentry/sentry-docs#12140 --------- Co-authored-by: Michelle Zhang <[email protected]>
evanh
pushed a commit
to getsentry/sentry
that referenced
this pull request
Dec 17, 2024
Closes #82142 Closes #66263 Relates to getsentry/sentry-docs#12140 --------- Co-authored-by: Michelle Zhang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12138
We did not really document well how to use user feedback with the loader. So I expanded this section in the docs to properly explain how it can be used.