feat(flags): document python UnleashIntegration #12216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 210 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
aliu39
commented
Dec 27, 2024
ryan953
reviewed
Dec 27, 2024
ryan953
reviewed
Dec 27, 2024
|
|
||
| ## Verify | ||
|
|
||
| The integration is tested by evaluating a feature flag using your Unleash SDK before capturing an exception. |
Member
There was a problem hiding this comment.
Suggested change
| The integration is tested by evaluating a feature flag using your Unleash SDK before capturing an exception. | |
| Test the integration by evaluating a feature flag using your Unleash SDK before capturing an exception. |
Member
Author
There was a problem hiding this comment.
This would apply to other python FF docs too
ryan953
reviewed
Dec 27, 2024
Comment on lines
70
to
71
| Visit the Sentry website and confirm that your error event has recorded the feature flag "test-flag", and its value | ||
| is equal to `test_flag_enabled`. |
Member
There was a problem hiding this comment.
a link into /issues would be good here.
Member
Author
There was a problem hiding this comment.
Same as above, this would apply to other python FF docs too
coolguyzone
approved these changes
Dec 30, 2024
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for updating! These changes look good, I've set this to 'draft' so we don't publish while it still has the 'TODO'.
cmanallen
requested changes
Jan 3, 2025
Co-authored-by: Colton Allen <[email protected]>
antonpirker
reviewed
Jan 7, 2025
cmanallen
approved these changes
Jan 7, 2025
aliu39
commented
Jan 7, 2025
aliu39
commented
Jan 7, 2025
michellewzhang
pushed a commit
that referenced
this pull request
Jan 7, 2025
* feat(flags): document python UnleashIntegration * ref versioning note * Reword note on get_variant * get_variant example * import os * Move to integrations folder * Add to integrations index * Review comments * Update docs/platforms/python/integrations/unleash/index.mdx Co-authored-by: Colton Allen <[email protected]> * Fix merge conflict * Remove unnecessary documentation of unleash client initialization * Remove os import * Add unleash imports --------- Co-authored-by: Anton Pirker <[email protected]> Co-authored-by: Colton Allen <[email protected]> Co-authored-by: Colton Allen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents getsentry/sentry-python#3888
Ref https://github.com/getsentry/team-replay/issues/514