Skip to content

Conversation

@michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Jan 2, 2025

localhost_3000_organization_integrations_feature-flag_unleash_ (1)

@vercel
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 8:20pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 8:20pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 8:20pm

@michellewzhang michellewzhang requested review from a team January 2, 2025 20:55
Comment on lines 14 to 15
* [JavaScript](/platforms/javascript/configuration/integrations/unleash/)
* [Python](/platforms/python/integrations/unleash/)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: these 2 links don't exist yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andrew will merge those soon. Let's wait until they're merged to merge this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and set this to 'draft' to make sure we don't merge before these urls are working.

@codecov
Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 189 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 195 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @michellewzhang, thanks for adding 🏄‍♂️

@cmanallen cmanallen marked this pull request as ready for review January 7, 2025 18:36
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellewzhang Let's ignore the JS sdk docs for now and just wait for the unleash sdk docs to fill that section in.

@michellewzhang michellewzhang merged commit 0f8b34d into master Jan 7, 2025
11 checks passed
@michellewzhang michellewzhang deleted the mz/unleash-docs branch January 7, 2025 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants