Skip to content

fix(changelog): Fix jumpy search #12284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(changelog): Fix jumpy search #12284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/changelog/src/client/components/list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {Category} from '@prisma/client';
import {MDXRemote, MDXRemoteSerializeResult} from 'next-mdx-remote';
import Link from 'next/link';
import {parseAsArrayOf, parseAsInteger, parseAsString, useQueryState} from 'nuqs';
import {Fragment} from 'react';
import {Fragment, useState} from 'react';
import {Article} from './article';
import {Pagination} from './pagination';
import {CategoryTag} from './tag';
Expand Down Expand Up @@ -35,7 +35,8 @@ function changelogEntryPublishDateToAddressableTag(date: Date) {
}

export function ChangelogList({changelogs}: {changelogs: ChangelogEntry[]}) {
const [searchValue, setSearchValue] = useQueryState('search', parseAsString);
const [searchValue, setSearchValue] = useState<string | null>('');
const [, setQuerySearchValue] = useQueryState('search', parseAsString);

const [monthAndYearParam, setMonthParam] = useQueryState('month');
const [selectedCategoriesIds, setSelectedCategoriesIds] = useQueryState(
Expand Down Expand Up @@ -207,7 +208,9 @@ export function ChangelogList({changelogs}: {changelogs: ChangelogEntry[]}) {
value={searchValue ?? ''}
onChange={e => {
setPageParam(null);
setSearchValue(e.target.value ? e.target.value : null);
const newSearchValue = e.target.value ? e.target.value : null;
setSearchValue(newSearchValue);
setQuerySearchValue(newSearchValue);
}}
placeholder="Search..."
className="form-input flex-1 rounded-md border border-gray-300 bg-white px-4 py-2 text-gray-900 focus:border-primary-500 focus:ring-primary-500"
Expand All @@ -217,6 +220,7 @@ export function ChangelogList({changelogs}: {changelogs: ChangelogEntry[]}) {
className={`${someFilterIsActive ? 'text-purple font-medium cursor-pointer' : 'text-gray-500 cursor-not-allowed'} hover:text-gray-700`}
onClick={() => {
setSearchValue(null);
setQuerySearchValue(null);
setSelectedCategoriesIds(null);
setMonthParam(null);
setPageParam(null);
Expand Down
Loading