Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Jan 24, 2025

DESCRIBE YOUR PR

Closes getsentry/sentry-native#1112

Latest Vercel Preview

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 10:01am

@codecov
Copy link

codecov bot commented Jan 24, 2025

Bundle Report

Changes will increase total bundle size by 2.86kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.62MB 1.74kB (0.02%) ⬆️
sentry-docs-client-array-push 9.3MB 1.12kB (0.01%) ⬆️
View changes by path for bundle: sentry-docs-server-cjs
File path Size Change
/[[...path]] 3.07MB 2.55MB (496.02%)
/platform-redirect 2.58MB 2.55MB (8300.71%)
/ 2.61MB 2.55MB (4116.1%)

@JoshuaMoelans
Copy link
Member Author

JoshuaMoelans commented Jan 24, 2025

Should we mention that in order to get these transactions/spans to show up, one has to set the sampling rate to 1 (or manually set sampled for the transaction to true and then also set max_spans>0?)

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
@JoshuaMoelans
Copy link
Member Author

Accidentally added commits from main separately (thanks VSCode)... Please let me know if it's best to just re-create the PR with only the actual changes to the native docs (in case merging this would break main).

@JoshuaMoelans
Copy link
Member Author

To avoid messy commit history, superseded by #12469

@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@JoshuaMoelans JoshuaMoelans deleted the feat/native/add-span-data branch May 6, 2025 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to attach data onto a span/transaction

9 participants