Skip to content

feat(apple): Attach data onto a span/transaction #12520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philipphofmann merged 1 commit into from
Jan 31, 2025
Merged

feat(apple): Attach data onto a span/transaction #12520

philipphofmann merged 1 commit into from
Jan 31, 2025

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 30, 2025 •
edited
Loading

DESCRIBE YOUR PR

Add docs for how to attach data onto span/transaction. Similar to #12367.

Fixes #12521.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:01pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Jan 30, 2025 3:01pm
develop-docs ⬜️ Ignored (Inspect) Jan 30, 2025 3:01pm

@philipphofmann philipphofmann requested a review from a team January 30, 2025 14:49
markushi
markushi approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philipphofmann philipphofmann merged commit 52fe1bc into master Jan 31, 2025
10 checks passed
@philipphofmann philipphofmann deleted the feat/apple-span-data branch January 31, 2025 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markushi markushi markushi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document how to attach data onto a span/transaction

3 participants

@philipphofmann @markushi