Skip to content

Conversation

@andreiborza
Copy link
Member

Removes the @sentry/browser imports making the snippets applicable to any sdk package.

Closes: #9728

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Removes the `@sentry/browser` imports making the snippets applicable to any
sdk package.

Closes: #9728
@andreiborza andreiborza requested a review from chargome March 6, 2025 15:51
@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 4:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 6, 2025 4:05pm
develop-docs ⬜️ Ignored (Inspect) Mar 6, 2025 4:05pm

@andreiborza andreiborza requested a review from s1gr1d March 6, 2025 15:51
@codecov
Copy link

codecov bot commented Mar 6, 2025

Bundle Report

Changes will increase total bundle size by 158.47kB (0.79%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 158.48kB (1.55%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 52.63kB 1.51MB 3.6%
../instrumentation.js 52.77kB 844.03kB 6.67% ⚠️
9523.js 52.63kB 820.09kB 6.86% ⚠️
../app/[[...path]]/page.js -1 bytes 530.72kB -0.0%
../app/[[...path]]/page.js.nft.json -2 bytes 382.6kB -0.0%
../app/platform-redirect/page.js.nft.json -2 bytes 382.51kB -0.0%
../app/platform-redirect/page.js -1 bytes 30.72kB -0.0%
731.js (New) 29.2kB 29.2kB 100.0% 🚀
../app/robots.txt/route.js 150 bytes 5.17kB 2.99%
../app/_not-found/page.js -1 bytes 4.58kB -0.02%
../app/_not-found/page.js.nft.json -2 bytes 356 bytes -0.56%
8899.js (Deleted) -28.9kB 0 bytes -100.0% 🗑️

App Routes Affected:

App Route Size Change Total Size Change (%)
/platform-redirect -1 bytes 2.58MB -0.0%
/ 297 bytes 2.61MB 0.01%
/[[...path]] -1 bytes 3.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
static/c_zHFDdFJR0OqZ1CsLwBZ/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/c_zHFDdFJR0OqZ1CsLwBZ/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/X1tN0EjKqlA0cUqycUNgv/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/X1tN0EjKqlA0cUqycUNgv/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@chargome
Copy link
Member

chargome commented Mar 7, 2025

Can you check what the failing 404 check is about?

@stephanie-anderson stephanie-anderson merged commit 0b1b678 into master Mar 7, 2025
10 of 11 checks passed
@stephanie-anderson stephanie-anderson deleted the ab/remove-import-from-userfeedback-sdk-samples branch March 7, 2025 11:11
@stephanie-anderson
Copy link
Contributor

@chargome fyi #12952

@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remix docs show import from @sentry/browser

4 participants