-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(docs): clarify database migrations #13026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
MichaelSun48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one clarifying suggestion, otherwise lgtm — definitely more clear than before. I'll let @wedamija stamp this in case we're missing something here
develop-docs/backend/application-domains/database-migrations/index.mdx
Outdated
Show resolved
Hide resolved
…ndex.mdx Co-authored-by: Michael Sun <[email protected]>
wedamija
reviewed
Mar 18, 2025
coolguyzone
reviewed
Mar 18, 2025
develop-docs/backend/application-domains/database-migrations/index.mdx
Outdated
Show resolved
Hide resolved
…ndex.mdx Co-authored-by: Alex Krawiec <[email protected]>
wedamija
approved these changes
Mar 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was just talking with @MichaelSun48 and I believe this is worded in a slightly confusing way. If the column you're looking to drop is not nullable, you should make it nullable first before removing references. lmk if this makes sense @wedamija