feat(platform): preview project name on top of DSN #13041
Conversation
also fixes a "copied" feedback z-index issue closes #13015
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 2.53kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
|
|
@a-hariti Thanks for the quick implementation! How should we deal with the project preview overlaying code? One idea that popped to my mind would be reducing the opacity when the cursor is on top of the preview, so that it is possible to view what's below the code, but not sure about that. https://sentry-docs-git-dsn-preview.sentry.dev/platforms/apple/guides/ios/ 
|
|
The ideal solution might be to track the user's gaze with AI and move the popup out of their eyesight 😂 |
|
I came up with this hack to add some margin to lines with clickable "keywords", it doesn't discriminate between DSN's or other things, but the worst case scenario is having an apparent extra line of whitespace, so it should do @philprime 
|
|
I think we shuold only show this for dsn, not for orgs and projects:
|
also rename styles file to be an actual TS file with the confusing .css.ts extention
|
@a-hariti Am I missing something or is the preview for DSNs not in there anymore? |
There was a problem hiding this comment.
Code looks fine but it does not seem to pick up all usage cases:
https://sentry-docs-git-dsn-preview.sentry.dev/platforms/javascript/guides/node/
https://sentry-docs-git-dsn-preview.sentry.dev/platforms/apple/guides/ios/
https://sentry-docs-git-dsn-preview.sentry.dev/platforms/dart/guides/flutter/
There was a problem hiding this comment.
Can we make the tooltip not to be picked up from selection?
I selected the text to copy it (instead of using the copy button) and it copied like this:
@import Sentry;
(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
[SentrySDK startWithConfigureOptions:^(SentryOptions *options) {
options.dsn = @"https://[email protected]/0example-org / example-project";
options.debug = YES; // Enabled debug when first installing is always helpful
// Adds IP for users.
// For more information, visit: https://docs.sentry.io/platforms/apple/data-management/data-collected/
options.sendDefaultPii = YES
}];
return YES;
}It seems to append the example-org / example-project to the DSN, while visually it is not selected.
This will cause UX issues with users who prefer to select code to copy it.
…ck copy or / Cmd+C
|
Good catch @philprime, it required some gymnastics, but I believe it's good to go now :) |
|
@a-hariti - what's the status of this one? |
|
I can take a look yes, otherwise @sergical is the man to ping now! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| document.addEventListener('selectionchange', handleSelectionChange); | ||
| return () => { | ||
| document.removeEventListener('selectionchange', handleSelectionChange); | ||
| }; |
There was a problem hiding this comment.
Bug: Selection Listener Fails with Dynamic Content
The selectionchange listener has a few issues. It captures .no-copy elements only once, missing dynamic additions, causing them to remain visible during selection. Restoring elements unconditionally sets display: 'inline', which can break their original layout. This hide/show behavior is visually jarring, and multiple CodeBlock instances add redundant global listeners.
| border: none; | ||
| color: var(--white); | ||
| transition: opacity 150ms; | ||
| z-index: 10000; |
There was a problem hiding this comment.
Not sure if this is really necessary, but should not interfere with anything else I think
also fixes a "copied" feedback z-index issue
closes #13015