-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(source-maps): Add doc explaining Debug IDs #13100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-maps): Add doc explaining Debug IDs #13100
Conversation
priscilawebdev
commented
Mar 24, 2025
- Contributes to We repeat Debug ID(s) over and over and it would be great if we could simplify the copies. sentry#85615
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 741 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
Thank you, I've read through it, and it makes sense to me. For RN I can add it later to https://docs.sentry.io/platforms/react-native/sourcemaps/debug-ids with RN-specific links to https://metrobundler.dev/docs/concepts and https://github.com/facebook/hermes/blob/main/doc/Features.md |
lforst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing I immediately saw
docs/platforms/javascript/common/sourcemaps/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Forstner <[email protected]>
| { | ||
| source: '/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/', | ||
| destination: '/platforms/javascript/sourcemaps/troubleshooting_js/debug-ids/', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the only change I made to the file, the rest was likely due to my code formatter
| @@ -1,36 +0,0 @@ | |||
| This article explains the inner workings of Artifact Bundles, and the implications of using them. Visit [Uploading Source Maps](/platforms/javascript/guides/react/sourcemaps/uploading/) if you're looking for our guides on how to upload source maps. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that this file is not being used.
| #### Bad Stack Trace | ||
|  | ||
|
|
||
| #### Good Stack Trace | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smeubank I will improve this in a follow-up. will try to have something similar to what we display in that hydration issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 👌
Gave it a pass for accuracy. All of my feedback is optional, apply as you see fit!
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| ## How Sentry uses Debug IDs | ||
|
|
||
| To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows: | |
| To use Debug IDs, you need **version 7.47.0** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically for nextjs at least i think v8 is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we hide this info then? I got it from somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't hide it, but maybe show it differently if the selected platform is Next.js. The nextjs sdk indeed supports sourcemaps from 8.0.0 onwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but it can be that JavaScript is selected and it provides an overall info so I have to say about Next JS, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
|
LGTM! I just read through and saw Luca addressed everything and more that I would've mentioned |
|
|
||
| ## How Sentry uses Debug IDs | ||
|
|
||
| To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically for nextjs at least i think v8 is required
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
…/debug-ids/index.mdx
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
…/debug-ids/index.mdx Co-authored-by: Luca Forstner <[email protected]>
docs/platforms/javascript/common/sourcemaps/troubleshooting_js/debug-ids/index.mdx
Outdated
Show resolved
Hide resolved
…/debug-ids/index.mdx
|
@priscilawebdev this PR is causing some 404 issues: https://github.com/getsentry/sentry-docs/actions/runs/14080645380/job/39432623331 |