Skip to content

Conversation

@priscilawebdev
Copy link
Member

@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 10:23am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 10:23am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 10:23am

@codecov
Copy link

codecov bot commented Mar 24, 2025

Bundle Report

Changes will increase total bundle size by 741 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.59MB 747 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.43MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 907.85kB -0.0%
9523.js -3 bytes 883.91kB -0.0%
../app/[[...path]]/page.js.nft.json 252 bytes 382.98kB 0.07%
../app/platform-redirect/page.js.nft.json 252 bytes 382.89kB 0.07%
../app/sitemap.xml/route.js.nft.json 252 bytes 380.87kB 0.07%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 869.05kB -0.0%
static/chunks/3464-*.js -3 bytes 394.39kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/vZz0QHBBVNxI7FIGzwcu1/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/vZz0QHBBVNxI7FIGzwcu1/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/lhMYwKv2B4K_hw_f9PDST/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/lhMYwKv2B4K_hw_f9PDST/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@krystofwoldrich
Copy link
Contributor

Thank you, I've read through it, and it makes sense to me.

For RN I can add it later to https://docs.sentry.io/platforms/react-native/sourcemaps/debug-ids with RN-specific links to https://metrobundler.dev/docs/concepts and https://github.com/facebook/hermes/blob/main/doc/Features.md

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I immediately saw

Comment on lines +588 to +591
{
source: '/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/',
destination: '/platforms/javascript/sourcemaps/troubleshooting_js/debug-ids/',
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only change I made to the file, the rest was likely due to my code formatter

@@ -1,36 +0,0 @@
This article explains the inner workings of Artifact Bundles, and the implications of using them. Visit [Uploading Source Maps](/platforms/javascript/guides/react/sourcemaps/uploading/) if you're looking for our guides on how to upload source maps.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that this file is not being used.

Comment on lines +56 to +60
#### Bad Stack Trace
![bad stack trace example](./img/bad-stack-trace.png)

#### Good Stack Trace
![good stack trace example](./img/good-stack-trace.png)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smeubank I will improve this in a follow-up. will try to have something similar to what we display in that hydration issue

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 👌

Gave it a pass for accuracy. All of my feedback is optional, apply as you see fit!


## How Sentry uses Debug IDs

To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows:
To use Debug IDs, you need **version 7.47.0** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically for nextjs at least i think v8 is required

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we hide this info then? I got it from somewhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't hide it, but maybe show it differently if the selected platform is Next.js. The nextjs sdk indeed supports sourcemaps from 8.0.0 onwards.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but it can be that JavaScript is selected and it provides an overall info so I have to say about Next JS, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

@smeubank
Copy link
Contributor

LGTM! I just read through and saw Luca addressed everything and more that I would've mentioned :shipit:


## How Sentry uses Debug IDs

To use Debug IDs, you need **version 7.47** or higher of one of our [JavaScript SDKs](https://github.com/getsentry/sentry-javascript). Once you're using a supported SDK, the process works as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically for nextjs at least i think v8 is required

@priscilawebdev priscilawebdev merged commit 8361005 into master Mar 26, 2025
12 of 13 checks passed
@priscilawebdev priscilawebdev deleted the priscila/feat/source-maps/add-debug-ids-doc branch March 26, 2025 10:25
@AbhiPrasad
Copy link
Member

@priscilawebdev this PR is causing some 404 issues: https://github.com/getsentry/sentry-docs/actions/runs/14080645380/job/39432623331

🌐 http://localhost:3000/platforms/javascript/guides/fastify/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/gatsby/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/gcp-functions/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/hapi/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/hono/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/koa/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/nestjs/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/nextjs/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/node/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/nuxt/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/react/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/react-router/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/remix/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/solid/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/solidstart/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/svelte/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/sveltekit/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/tanstackstart-react/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/vue/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

🌐 http://localhost:3000/platforms/javascript/guides/wasm/sourcemaps/troubleshooting_js/debug-ids
    - [Debug IDs](/platforms/javascript/sourcemaps/debug-ids/#what-are-debug-ids)

👉 Note: the markdown syntax is not necessarily present on the source files, but the links do exist on the final pages

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants