Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 31, 2025

DESCRIBE YOUR PR

This PR changes the styling of our code highlights based on feedback I received after #12983:

  • left border changed from pink to purple to avoid mistaking it for a negative diff code line
  • fixed too much left padding for individual lines in highlight block
  • narrowed down vertical padding of highlight blocks. I personally still prefer the current 2px padding over no padding at all but happy to debate this further :)
  • cleaned up some unnecessary css values

Before:

image

After:

image

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 10:29am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 10:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2025 10:29am

@Lms24 Lms24 self-assigned this Mar 31, 2025
@Lms24 Lms24 requested review from andreiborza and lforst March 31, 2025 10:04
@codecov
Copy link

codecov bot commented Mar 31, 2025

Bundle Report

Changes will increase total bundle size by 49 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.6MB 22 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.44MB 27 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 911.63kB -0.0%
9523.js -3 bytes 887.68kB -0.0%
../app/[[...path]]/page.js 31 bytes 538.98kB 0.01%

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 31 bytes 3.09MB 0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.67kB -0.0%
static/chunks/8931-*.js -3 bytes 397.42kB -0.0%
static/chunks/app/[[...path]]/page-*.js 33 bytes 77.89kB 0.04%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/OJv5XmLA1Bs9xeS1Kf4U6/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/OJv5XmLA1Bs9xeS1Kf4U6/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/LaCJWV-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/LaCJWV-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@Lms24
Copy link
Member Author

Lms24 commented Mar 31, 2025

Another example:

Before:
image

After:
image

@lforst
Copy link
Contributor

lforst commented Mar 31, 2025

b e a u t i f u l

@Lms24 Lms24 merged commit 04b4f75 into master Mar 31, 2025
13 checks passed
@Lms24 Lms24 deleted the lms/ref-code-highlight-styling branch March 31, 2025 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants