Skip to content

fix(develop): clarify trace context's client_sample_rate #13174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjq merged 2 commits into from
Apr 10, 2025
Merged

fix(develop): clarify trace context's client_sample_rate #13174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f98cf
fix(develop): clarify trace context's client_sample_rate
mjq Mar 31, 2025
bd11258
Alex's suggested copy change
mjq Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion develop-docs/sdk/data-model/event-payloads/contexts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ Additional information that allows Sentry to connect multiple transactions, span

`client_sample_rate`

: _Optional_. The client-side sample rate.
: _Optional_. The client-side sample rate. This field will be populated by relay. Incoming values are ignored.
Copy link
Member

@Dav1dde Dav1dde Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is fully correct, we have a code path which re-creates the DSC when the parent project is not in the same org or missing.

Maybe @jan-auer can also chime in?

Copy link
Member Author

@mjq mjq Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was the subject of @jan-auer's recent changes. The DSC generation happens here. But the sample rate is taken from the incoming DSC, never from the trace context's client_sample_rate - that field is never read, only set (taken from the DSC, after being recreated if necessary).

Hopefully Jan can confirm.

Copy link
Member

@jan-auer jan-auer Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, it happens here: https://github.com/getsentry/relay/blob/cbf72c2930ad01ed0d780e36968088cd6a051878/relay-event-normalization/src/event.rs#L354-L356


- Example: `0.1`

Expand Down