Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 4, 2025

DESCRIBE YOUR PR

Adds a general hint and a second information box specific to Cloudflare.

image

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 10:24am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 4, 2025 10:24am
develop-docs ⬜️ Ignored (Inspect) Apr 4, 2025 10:24am

@s1gr1d s1gr1d requested review from Lms24 and mydea April 4, 2025 10:09
@Lms24
Copy link
Member

Lms24 commented Apr 4, 2025

Does the esbuild flow work for wrangler?

@codecov
Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/ZsXoWE8U7-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ZsXoWE8U7-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/tOeYYeBpLdzU-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/tOeYYeBpLdzU-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

</Alert>

<PlatformSection supported={['javascript.cloudflare']}>
<Alert>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid double-alerts here? So, can we just put this content in the alert above, when on cloudflare?

@s1gr1d s1gr1d marked this pull request as draft April 23, 2025 07:29
@s1gr1d
Copy link
Member Author

s1gr1d commented Apr 23, 2025

I turned it to draft because after trying this, I found out it's actually not that easy. Wrangler has a source map setting but does not allow adding esbuild plugins. The only option is to add a custom build and I am not sure if people want to do this.

Assigning @AbhiPrasad to take over this PR after he finishes getsentry/sentry-wizard#824 (we wrote about this internally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants