-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(source-maps): Add hints for bundler selection in wizard #13232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Does the esbuild flow work for wrangler? |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| </Alert> | ||
|
|
||
| <PlatformSection supported={['javascript.cloudflare']}> | ||
| <Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid double-alerts here? So, can we just put this content in the alert above, when on cloudflare?
|
I turned it to draft because after trying this, I found out it's actually not that easy. Wrangler has a source map setting but does not allow adding esbuild plugins. The only option is to add a custom build and I am not sure if people want to do this. Assigning @AbhiPrasad to take over this PR after he finishes getsentry/sentry-wizard#824 (we wrote about this internally). |
DESCRIBE YOUR PR
Adds a general hint and a second information box specific to Cloudflare.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: