feat(develop): Add driver_version to GPU context
#13235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
Shall I also add a label string to the Sentry UI? |
AbhiPrasad
reviewed
Apr 4, 2025
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
we'll need to add this to https://github.com/getsentry/relay/blob/master/relay-event-schema/src/protocol/contexts/gpu.rs as well
Contributor
|
Hey @AbhiPrasad can you take a look at this one? Thanks! |
AbhiPrasad
approved these changes
May 13, 2025
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
We can merge - we just need the relay PR after this.
Dav1dde
pushed a commit
to getsentry/relay
that referenced
this pull request
May 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Electron SDK has started including this:
https://github.com/getsentry/sentry-electron/blob/bcfdbfec0c6d2f3eb28430fb8d0121d4b61123ac/src/main/integrations/gpu-context.ts#L20