Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Apr 4, 2025

DESCRIBE YOUR PR

Tested with the Spring sample and it works.
Closes #11475

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 2:46pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2025 2:46pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2025 2:46pm

@codecov
Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/geuxSZUMh91_sYzy5NiiC/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/geuxSZUMh91_sYzy5NiiC/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/JGyQ68mVRp_IM3Jr8RGF5/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/JGyQ68mVRp_IM3Jr8RGF5/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@lcian lcian enabled auto-merge (squash) April 17, 2025 14:15
@lcian lcian merged commit 95ad517 into master Apr 17, 2025
15 checks passed
@lcian lcian deleted the lcian-patch-1 branch April 17, 2025 14:46
codyde added a commit that referenced this pull request Apr 19, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits)
  refactor: migrate Golang and related guides to inline product options syntax (#13413)
  refactor: migrate DotNet sdks to inline product options syntax (#13415)
  add note of the switch sdk (#13431)
  Update spelling in examples.mdx (#13378)
  ref(replay): clarify web & mobile distinction in product docs (#13447)
  fix(java): fix `RestTemplate` auto-instrumentation guide (#13236)
  refactor: migrate Python and related guides to inline product options syntax (#13412)
  Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435)
  docs(tracing): Add docs for Previous and Next trace (#13406)
  docs(js): Create Svelte Quick Start guide (#13387)
  Update Profiling SDK version number for iOS/macOS (#13429)
  remove note that workflow notifications alert on new feedback (#13384)
  fix(dart): 404 link (#13430)
  feat(Godot): Update options screenshot on the landing page (#13428)
  add senddefaultpii to powershell (#13426)
  powershell senddefaultpii landing page (#13427)
  chore: update powershell min version requirement (#13425)
  docs(replays): add count_traces to searchable properties (#13422)
  docs(js): Add `sendDefaultPii: true` to all init calls (#13408)
  docs(dotnet): Add `SendDefaultPii = true` option (#13423)
  ...
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* fix(java): fix `RestTemplate` autoinstrumentation guide

* Update automatic-instrumentation.mdx

* Update automatic-instrumentation.mdx
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java Spring automatic RestTemplate Instrumentation is confusing

3 participants