feat(js): Remove Performance metrics page #13255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 291 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Dhrumil-Sentry
approved these changes
Apr 7, 2025
Lms24
approved these changes
Apr 7, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
As discussed, I think some kind of note that setMeasurement users should ideally switch to setAttribute would be great but not a deal breaker for me.
Related, we should deprecate the APIs SDK-side as discussed today once we know the unit replacement strategy.
This is not really needed anymore, folks should just use span metrics. I also noticed a redirect was missing for the non-guide variant of the page.
mydea
force-pushed
the
fn/remove-measurements
branch
from
ce0674e to
cde6728
Compare
Member
Author
|
I added a note at the bottom of the span metrics page explaining that measurements are deprecated and span metrics should be used instead :) |
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really needed anymore, folks should just use span metrics. I also noticed a redirect was missing for the non-guide variant of the page.