Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 7, 2025

We use this quite a lot to just generically mean "heading", but this is incorrect - a h6 has to be structure below a h5, not just randomly. This PR changes this to use a different heading that makes more sense or just a div+class instead. Nothing should change visually.

@mydea mydea requested review from a-hariti, chargome, codyde and lforst April 7, 2025 11:41
@mydea mydea self-assigned this Apr 7, 2025
@vercel
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:05pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2025 2:05pm

@codecov
Copy link

codecov bot commented Apr 7, 2025

Bundle Report

Changes will increase total bundle size by 273 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB 121 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB 152 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/css/*.css 53 bytes 14.16kB 0.38%
static/css/*.css -47 bytes 18.66kB -0.25%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/chunks/818-*.js -28 bytes 42.81kB -0.07%
static/chunks/4746-*.js 180 bytes 20.21kB 0.9%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/38nEZnQtoFsXaUTXR7S4Q/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/38nEZnQtoFsXaUTXR7S4Q/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/7EHOZVYWY2yyBHK_nuoVk/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/7EHOZVYWY2yyBHK_nuoVk/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/818-*.js:

  • ./src/components/sidebarTableOfContents/index.tsx → Total Size: 6.87kB

  • ./src/components/sidebarTableOfContents/style.module.scss → Total Size: 277 bytes

Files in static/chunks/4746-*.js:

  • ./src/components/sidebar/style.module.scss → Total Size: 248 bytes

  • ./src/components/search/search.module.scss → Total Size: 1.3kB

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js -54 bytes 559.37kB -0.01%
2065.js 4 bytes 82.48kB 0.0%
7269.js 180 bytes 29.68kB 0.61%

Files in ../app/[[...path]]/page.js:

  • ./src/components/guideGrid.tsx → Total Size: 2.04kB

Files in 2065.js:

  • ./src/components/sidebar/style.module.scss → Total Size: 236 bytes

  • ./src/components/sidebar/defaultSidebar.tsx → Total Size: 2.89kB

  • ./src/components/sidebarTableOfContents/style.module.scss → Total Size: 268 bytes

  • ./src/components/dynamicNav.tsx → Total Size: 5.13kB

  • ./src/components/sidebar/style.module.scss → Total Size: 236 bytes

  • ./src/components/sidebarTableOfContents/index.tsx → Total Size: 6.74kB

  • ./src/components/sidebar/platformSidebar.tsx → Total Size: 2.03kB

  • ./src/components/sidebarTableOfContents/index.tsx → Total Size: 520 bytes

Files in 7269.js:

  • ./src/components/search/search.module.scss → Total Size: 1.34kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -54 bytes 3.11MB -0.0%
/ 180 bytes 2.61MB 0.01%

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

mydea and others added 2 commits April 7, 2025 15:45
We use this quite a lot to just generically mean "heading", but this is incorrect - a h6 has to be structure below a h5, not just randomly. This PR changes this to use a different heading that makes more sense or just a div+class instead. Nothing should change visually.
@mydea mydea force-pushed the fn/replace-h6-usage branch from e0af6ca to 28a4843 Compare April 7, 2025 13:45
@mydea mydea merged commit 9bebcf6 into master Apr 7, 2025
13 checks passed
@mydea mydea deleted the fn/replace-h6-usage branch April 7, 2025 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants