Skip to content

Conversation

@tustanivsky
Copy link
Collaborator

@tustanivsky tustanivsky commented Apr 8, 2025

This PR introduces the following changes to Unreal SDK docs:

@vercel
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Apr 25, 2025 9:28am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 9:28am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 9:28am

@codecov
Copy link

codecov bot commented Apr 22, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/XkZQmu5aSYlrCfuhKTj88/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/XkZQmu5aSYlrCfuhKTj88/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1KMm52c4ApvWB1S8bd1vZ/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/1KMm52c4ApvWB1S8bd1vZ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%


<ConfigKey name="attach-game-log">

When enabled, game log file is automatically attached to all events captured if the current build configuration allows logging.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When enabled, game log file is automatically attached to all events captured if the current build configuration allows logging.
When enabled, and when the current build configuration supports logging, the game's log file is automatically attached to all events.


<ConfigKey name="attach-gpu-dump">

When enabled, [Nsight Aftermath](https://developer.nvidia.com/nsight-aftermath) mini-dump file is automatically attached to GPU crash events captured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When enabled, [Nsight Aftermath](https://developer.nvidia.com/nsight-aftermath) mini-dump file is automatically attached to GPU crash events captured.
When enabled, a [Nsight Aftermath](https://developer.nvidia.com/nsight-aftermath) minidump file is automatically attached to captured GPU crash events.


<Alert>

This feature is currently supported only for Nvidia GPUs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This feature is currently supported only for Nvidia GPUs.
This feature is currently limited to Nvidia GPUs.


These options can be used to hook the SDK in various ways to customize the reporting of events.

The callbacks you set as hooks will be called on the thread where the event happened. If the event occurs on a non-game thread during garbage collection the callback will not be invoked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The callbacks you set as hooks will be called on the thread where the event happened. If the event occurs on a non-game thread during garbage collection the callback will not be invoked.
The hooks you set as callbacks will be called and executed on the same thread where the event happened. Note that if the event occurs on a non-game thread during garbage collection then then callback will not be invoked.

Comment on lines +54 to +55
virtual USentryBreadcrumb* HandleBeforeBreadcrumb_Implementation(USentryBreadcrumb* Breadcrumb, USentryHint* Hint)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
virtual USentryBreadcrumb* HandleBeforeBreadcrumb_Implementation(USentryBreadcrumb* Breadcrumb, USentryHint* Hint)
{
virtual USentryBreadcrumb* HandleBeforeBreadcrumb_Implementation(USentryBreadcrumb* Breadcrumb, USentryHint* Hint)
{

They should have the same indentation, right?


<Alert>

To avoid warnings during the build for licensee versions of Unreal Engine, the `EngineVersion` key is not set in the `Sentry.uplugin` for the `github` package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To avoid warnings during the build for licensee versions of Unreal Engine, the `EngineVersion` key is not set in the `Sentry.uplugin` for the `github` package.
To avoid warnings during the build for license versions of Unreal Engine, the `EngineVersion` key is not set in the `Sentry.uplugin` for the `github` package.

I might be reading that wrong tho.

@tustanivsky tustanivsky merged commit a2dfb35 into master May 5, 2025
15 checks passed
@tustanivsky tustanivsky deleted the ue-docs-update branch May 5, 2025 13:27
@tustanivsky tustanivsky restored the ue-docs-update branch May 5, 2025 13:34
@tustanivsky tustanivsky deleted the ue-docs-update branch May 5, 2025 13:36
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants