fix(tanstackstart): added missing imports, highlights, and typos #13301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
AbhiPrasad
approved these changes
Apr 9, 2025
Member
We'll need to make another guide for onboarding |
sfanahata
approved these changes
Apr 21, 2025
Contributor
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
@nikolovlazar - this looks good to merge. The preview and updates render just fine.
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few missing imports, highlights, and also a typo in the TanStack Start guide:
wrapCreateRootRouteWithSentryimportQuestion: a similar guide is shown in Sentry itself after you create a project. Would this PR fix that one as well, or should I open a separate PR on that repo?