Add SentryNavigatorObserver in onboarding #13309
Conversation
Without the SentryNavigatorObserver tracing with spans and errors on page loads and navigations doesn't work OOTB This adds SentryNavigatorObserver() to config snippets in the main page and manual - it is a bit confusing as a follow up to wizard to have any config - what doesn't the wizard do? - explanation for the SentryWidget and SentryNavigatorObserver is needed in these docs. As I don't get what changes in the product experience from this config - do i need all this dart and custom? - i think an image of a page load with an error would help here for the "reason why" - these changes are the same in both files, should it be an include?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| // When tracing is enabled, add SentryNavigatorObserver to connect | ||
| // page navigations, spans, and errors in a single trace | ||
| navigatorObservers: [ | ||
| SentryNavigatorObserver() | ||
| ], |
There was a problem hiding this comment.
this is not added to a generic MyApp, it will depend on what framework the user uses
for example:
final router = GoRouter(
routes: ...,
observers: [SentryNavigatorObserver()],
);vs
return MaterialApp(
title: 'My Widget',
home: MyWidget(),
navigatorObservers: [
SentryNavigatorObserver()
],
);Not sure how we are going to unify this
There was a problem hiding this comment.
@buenaflor how many frameworks are there? is there a finite number of options, or is that there are X frameworks, and then they can also just do it free form to extent however they want?
Is there a to 2-3 ways a user might set it up?
There was a problem hiding this comment.
there are plenty frameworks but according to download stats these two are the most popular (the first one above is GoRouter a 3rd party package and the second one is the default one provided by Flutter)
Maybe we could add a note that for all other cases the user has to add the navigatorobserver manually but don't provide exact instructions how?
Without the SentryNavigatorObserver tracing with spans and errors on page loads and navigations doesn't work OOTB
This adds SentryNavigatorObserver() to config snippets in the main page and manual
Open points: