Skip to content

fix(style): Ensure scrollbar is consistent #13354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(style): Ensure scrollbar is consistent #13354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/sidebar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ export async function Sidebar({path, versions}: SidebarProps) {
});

return (
<aside className={styles.sidebar}>
<aside className={`${styles.sidebar} py-3`}>
<input type="checkbox" id={sidebarToggleId} className="hidden" />
<style>{':root { --sidebar-width: 300px; }'}</style>
<div className="md:flex flex-col items-stretch overflow-auto">
<div className="platform-selector">
<div className="platform-selector px-3">
<div className="mb-3">
<PlatformSelector
platforms={platforms}
Expand All @@ -98,7 +98,7 @@ export async function Sidebar({path, versions}: SidebarProps) {
</div>
)}
</div>
<div className={styles.toc}>
<div className={`${styles.toc} px-3`}>
<ScrollActiveLink activeLinkSelector={activeLinkSelector} />
<SidebarLinks path={path} />
</div>
Expand Down
10 changes: 1 addition & 9 deletions src/components/sidebar/style.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
flex-direction: column;
width: 100%;
z-index: 10;
padding: 1.5rem 1rem;
border-right: 1px solid var(--border-color);
position: fixed;
display: none;
Expand Down Expand Up @@ -70,16 +69,9 @@
}

.toc {
overflow: auto;
font-size: 0.875rem;
flex: 1;
overflow-y: hidden;
overflow-x: hidden;

// https://stackoverflow.com/questions/35484742/hide-useless-scrollbars-that-show-up-on-windows-only
&:hover {
overflow-y: auto;
}
overflow: auto;

@media only screen and (min-width: 768px) {
display: block;
Expand Down
Loading