Skip to content

Conversation

@a-hariti
Copy link
Collaborator

related to #13361

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 11:21am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 16, 2025 11:21am
develop-docs ⬜️ Ignored (Inspect) Apr 16, 2025 11:21am

@codecov
Copy link

codecov bot commented Apr 16, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/ol5WzhtXEpWCJpjTV2dAT/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/ol5WzhtXEpWCJpjTV2dAT/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/2VhwsOCH9j1veuRMrpPKE/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/2VhwsOCH9j1veuRMrpPKE/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@cleptric
Copy link
Member

Hmm, the problem in PHP is that traces_sample_rate by itself does nothing. You need to manually create a transaction. Same with profiling, it requires a transaction.

@a-hariti
Copy link
Collaborator Author

I just migrated what was already there

do you think we should improve docs before merging @cleptric?

@cleptric
Copy link
Member

Ahh, good point. Yes, though I have to put this work back to in two weeks, as I'm OOO. We can merge this as is then.

@a-hariti a-hariti merged commit fa3e583 into master Apr 16, 2025
15 checks passed
@a-hariti a-hariti deleted the migrate-onboarding-php branch April 16, 2025 18:29
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants