fix(platform): Avoid IntersectionObserver issues #13420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
mydea
commented
Apr 16, 2025
| const headings = tocItems.map(item => item.element); | ||
| headings.forEach(heading => observer.observe(heading)); | ||
| return () => headings.forEach(heading => observer.unobserve(heading)); | ||
| return () => observer.disconnect(); |
Member
Author
There was a problem hiding this comment.
I think this is better, we can tear down the whole observer like this I believe? I can't even find unobserve here: https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/disconnect 🤔
Bundle ReportChanges will decrease total bundle size by 19 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
|
chargome
approved these changes
Apr 16, 2025
| const rootMarginBottomRaw = (2 / 3) * window.innerHeight - rootMarginTop; | ||
| const rootMarginBottom = Math.floor(rootMarginBottomRaw); | ||
| const rootMarginBottomRaw = (2 / 3) * innerHeight - rootMarginTop; | ||
| const rootMarginBottom = Math.floor(rootMarginBottomRaw) * -1; |
Member
There was a problem hiding this comment.
Strange that we still run into this, I thought the floor call here fixed this 🤔
We have a lot of issues like this: https://sentry.sentry.io/issues/5543047544/?project=1267915 TBH not sure how that happens, but I guess we can try to be defensive here. Maybe inner height is missing somehow?
mydea
force-pushed
the
fn/fix-intersection-observer
branch
from
2a93bf0 to
4fa0baa
Compare
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
We have a lot of issues like this: https://sentry.sentry.io/issues/5543047544/?project=1267915 TBH not sure how that happens, but I guess we can try to be defensive here. Maybe inner height is missing somehow?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of issues like this: https://sentry.sentry.io/issues/5543047544/?project=1267915
TBH not sure how that happens, but I guess we can try to be defensive here. Maybe inner height is missing somehow?