fix(platform): Add scrollable horizontal overflow #13598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 34 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
|
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Hey @chargome, thanks for this PR, and sorry I missed the review notification.
Although this is probably better than what we had before, I don't think it's ideal.
Here's a screen recording to demonstrate (made on this page from the preview):
Screen.Recording.2025-05-09.at.14.03.21.mov
Specifically, what I think should be improved:
- It's a bit difficult to tell that this page is horizontally scrollable. Maybe, this could be fixed by adding a shadow border on the right side when the page is scrollable horizontally, which makes it look like the right sidebar is "above" the rest of the horizontally scrollable portion
- Also, rather than having the whole docs page scroll horizontally, I think it would be better to have only the overflowing portion (in this case, the table) scroll horizontally.
I'll approve the PR if you think it's too much effort to address these suggestions here, but I think it would be best to create an issue for them, in that case.
Contributor
|
@chargome - are you still working on this one? |
Member
Author
|
This became obsolete with the layout changes, sorry that this one fell under the radar! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UI bugs with overflowing tables etc.