Skip to content

Conversation

@chargome
Copy link
Member

The previous approach was not working on safari, so we just conditionally render the icon altogether now.

@chargome chargome requested a review from mydea May 16, 2025 08:24
@chargome chargome self-assigned this May 16, 2025
@vercel
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:38am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) May 16, 2025 8:38am

@codecov
Copy link

codecov bot commented May 16, 2025

Bundle Report

Changes will decrease total bundle size by 946 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.19MB -380 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB -566 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js -371 bytes 584.27kB -0.06%

Files in ../app/[[...path]]/page.js:

  • ./src/components/expandable/index.tsx → Total Size: 460 bytes

  • ./src/components/expandable/index.tsx → Total Size: 3.16kB

  • ./src/components/expandable/style.module.scss → Total Size: 182 bytes

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -371 bytes 3.13MB -0.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/css/*.css -171 bytes 1.32kB -11.47%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/chunks/app/[[...path]]/page-*.js -389 bytes 78.83kB -0.49%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/B5-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/B5-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/hz4GtQN6nHgVlr7NliVK6/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/hz4GtQN6nHgVlr7NliVK6/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/expandable/index.tsx → Total Size: 3.5kB

  • ./src/components/expandable/style.module.scss → Total Size: 200 bytes

@chargome chargome merged commit 5d9101e into master May 19, 2025
15 checks passed
@chargome chargome deleted the cg-fix-alert-webkit branch May 19, 2025 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants