Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented May 21, 2025

This fixes some content that was added in #13752:

  1. Moves logs down below tracing, as that is IMHO more important (and stable - logs is still experimental 😬 ) (should not affect LLMs too much, but for consistency sake with other things...)
  2. Remove the line about adding the logger integration, which does not exist
  3. Fix the tracing snippets to be better - what we recommended there was actually not what we would want users to do.

@mydea mydea requested review from chargome, codyde and nikolovlazar May 21, 2025 14:29
@mydea mydea self-assigned this May 21, 2025
@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 3:16pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 3:16pm

@codecov
Copy link

codecov bot commented May 21, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/xWJ2eYs0Lh-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/xWJ2eYs0Lh-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/HodQji4Q2RX769hpG5d_-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/HodQji4Q2RX769hpG5d_-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@mydea
Copy link
Member Author

mydea commented May 21, 2025

@codyde good point, I added this entry to the logs section everywhere:

  • Enable logging in Sentry using Sentry.init({ _experiments: { enableLogs: true } })

Copy link
Contributor

@codyde codyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codyde codyde merged commit bcf71d0 into master May 22, 2025
13 checks passed
@codyde codyde deleted the fn/fix-code-snippets branch May 22, 2025 04:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants