fix(ui): Only copy CodeBlock expandable content #13973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change all `code` elements would be copied, so if the markdown content inside a expandable alert included single-backtick style `<code>whatever</code>` nodes, those would end up in the copied content. The intention of this component is definitely intended to just copy the CodeBlock content.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
michellewzhang
approved these changes
Jun 9, 2025
Bundle ReportChanges will increase total bundle size by 49 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
|
Member
|
Dupe of #13972 - we could do both changes, though I'm not sure this change with the way its struct ured wouldn't break anything else |
auto-merge was automatically disabled
June 10, 2025 16:51
Pull request was closed
evanpurkhiser
deleted the
evanpurkhiser/fix-ui-only-copy-codeblock-expandable-content
branch
Member
Author
|
Cursor change seems fine for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change all
codeelements would be copied, so if themarkdown content inside a expandable alert included single-backtick
style
<code>whatever</code>nodes, those would end up in the copiedcontent.
The intention of this component is definitely intended to just copy the
CodeBlock content.