✨ feat(integrations): add github domain checker #14011
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 9.56kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
|
Should the form input darken in dark mode, similar to the search input at the top of the page?
|
leeandher
left a comment
leeandher
left a comment
There was a problem hiding this comment.
this is cool! hopefully it makes things less confusing
docs/organization/integrations/source-code-mgmt/github/index.mdx
Outdated
Show resolved
Hide resolved
| const isGitHubCom = | ||
| domain.toLowerCase().trim() === 'github.com' || | ||
| domain.toLowerCase().trim() === 'https://github.com'; |
There was a problem hiding this comment.
I think maybe we should relax this a bit, if I add my GH user it recommends the wrong installation. probably user error by adding my username after but still!
There was a problem hiding this comment.
i relazed this just a bit so it checks if the input starts with github.com
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <div className="text-sm font-medium mb-2">Recommended Installation:</div> | ||
| {isGitHubCom ? ( | ||
| <div className="text-green-700 bg-green-50 dark:text-green-300 dark:bg-green-900/30 p-3 rounded-md"> | ||
| <div className="mb-2"> |
There was a problem hiding this comment.
nit: I dont think the margin here is necessary, it makes for uneven spacing.
| </div> | ||
| ) : ( | ||
| <div className="text-blue-700 bg-blue-50 dark:text-blue-300 dark:bg-blue-900/30 p-3 rounded-md"> | ||
| <div className="mb-2"> |
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
folks are often confused about if they should use the Github Integration or the Github Enterprise Integration. to try to combat this, i added a component (based off of
CreateGitHubAppForm) which parses the domain the user inputs and tells them what integration to installScreen.Recording.2025-06-11.at.9.20.09.PM.mov